Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requestToken and submitTokens endpoints for mails #109

Merged
merged 16 commits into from
Jul 12, 2024

Conversation

@@ -0,0 +1,54 @@
// TODO : Add Mailer to @twake/utils after creating a union-type Config = clientServerConfig | identityServerConfig | federatedIdentityServerConfig ... and changing to Config to the right subtype in the relevant files

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
)
let initial_device_display_name
if (deviceRows.length > 0) {
// TODO : Refresh access tokens using refresh tokens and invalidate the previous access_token associated with the device

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
next_link?: string
}

// TODO : Redirect to next_link from requestToken if present

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@@ -19,6 +19,8 @@
sid: string
}

// TODO : Redirect to next_link from requestToken if present

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
packages/matrix-client-server/src/register/index.ts Dismissed Show dismissed Hide dismissed
packages/matrix-client-server/src/register/index.ts Dismissed Show resolved Hide resolved
packages/matrix-client-server/src/matrixDb/index.ts Dismissed Show dismissed Hide dismissed
@BichraiX BichraiX requested a review from guimard July 11, 2024 16:03
…en. Added method to check if next_link is a correct URL in Utils and associated tests. Added TODO in submitToken to fill the mail Template with the right code to send back to the client
}).toString()
)
// set token
// .replace(/__token__/g, secret) // This part is commented out for now since I don't know what the code is supposed to be TODO : Send a correct code

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@@ -76,6 +77,8 @@
sid
}).toString()
)
// set token
// .replace(/__token__/g, secret) // This part is commented out for now since I don't know what the code is supposed to be TODO : Send a correct code

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@BichraiX BichraiX requested a review from guimard July 12, 2024 10:41
@guimard guimard merged commit c09bc66 into full-id-service Jul 12, 2024
8 checks passed
@BichraiX BichraiX deleted the client-server-request-token branch July 12, 2024 11:58
@BichraiX BichraiX mentioned this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants